Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design change: use a single Adapter per each ERC20/xERC20 pairs #12

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

gitmp01
Copy link
Collaborator

@gitmp01 gitmp01 commented Jul 26, 2024

This design change avoids the need of the XERC20Registry contract.
The registry approach has raised the following problems:

  • Ownership: can't be transferred to token owners, since it may raise a censorship problem. Also it can't be renounced entirely because noone can register pairs anymore.
  • Registration: apply a restriction of a given pair only to the ERC20 owner has been taken into account, however it isn't possible to get the owner of a ERC20 on chains where it isn't deployed (the registry is meant to be deployed on each supported chain).

This has been avoided by setting the pairs in the Adapter's constructor, the main disadvantage is that the dApp has to keep track of each official Adapter address for each pair in order to interact with them.

@gitmp01 gitmp01 merged commit f571bc2 into master Jul 26, 2024
1 check passed
@gitmp01 gitmp01 deleted the feat/standalone-adapter branch July 26, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant